Skip to content

Package cleanup #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2024
Merged

Package cleanup #48

merged 2 commits into from
Oct 7, 2024

Conversation

DougGregor
Copy link
Member

Two small cleanups to the package itself to make it slightly easier to use:

  • Re-export JavaRuntime from the JavaKit module
  • Don't build everything as dynamic libraries. It's just the top-level Swift libraries (like the example code) that need to be dynamic

@DougGregor
Re-export JavaRuntime from the JavaKit module
4508462 
There's no way to use JavaKit without the JavaRuntime module, so ensure that
it's always available.
@DougGregor
Only build the JavaKitExample shared library itself as a dynamic library
39d76f8 
Everything else can be static
@DougGregor DougGregor merged commit 8631e5d into swiftlang:main Oct 7, 2024
8 of 9 checks passed
@DougGregor DougGregor deleted the package-cleanup branch October 7, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DougGregor